On Sun, 9 Jun 2002, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | Allan Rae <[EMAIL PROTECTED]> writes: > > > | | On Wed, 5 Jun 2002, Allan Rae wrote: [...] > InsetIterator is use twice... > > the use in buffer.C:3972 will work fine with >= (even better probably) > the use in BufferView2.C:203 ditto here. > > IMHO the correct fix will be the one-char patch that changes a '=' to > '>' in InsetIterator.
True for those two uses that are currently in the sources. However, I figured, since you cleaned up all the code to use exact matching in a bunch of places and many of those places look almost identical to InsetIterator, one day soon one of us will start replacing the explicit code with calls to InsetIterator and in that case we would almost certainly want the two distinct functions. I don't have a problem with the one char change -- that was my original fix but upon further consideration (above) I decided the fix I provided was better (although the one char fix is probably all we want for 1.2.x). Allan. (ARRae)
