Herbert Voss <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| absolutely cool!!!
| it was you (!) and JMarc who said, that we should support
| ALL floats with the definitions in the layout!
Not non-standard floats.
We do not invent float styles for ourselves.
>> And I really do not like this one:
>> +FloatList::FloatList(string const & newFloatCmds) {
>> + if (!newFloatCmds.empty()) {
>> + if (!list.empty())
>> + list.clear();
>> + int entry = 0;
>> + // 1.line
>> + string str = token(newFloatCmds,'\n',entry);
>> + while (!str.empty()) {
>> + newFloat(str);
>> + // next line
>> + str = token(newFloatCmds,'\n',++entry);
>> + }
>> + }
>
>
>> }
>
>
| what about to tell the reason why ...
You are using plain string to buld the float instide the list, apart
from that I cannot even understand what it is doing.
|
>> You seem to be blurring the difference between a Float and a
>> FloatList.
>
>
| I do not think so
str2float, passing a float as string to FloatList etc.
>
>> Why does it have to be a difference between wide and non-wide floats?
>
>
| I do not understand .. where do you saw a difference?
In that you add an explicit "wide" parameter.
>> Does it really make sense to ahve a "algorithm" and an "algorithm*"
>> with completely different definitions?
>
>
| It's only possible to define a float and not a wide one.
but as I read it with your patch: it will be possible to define a
float _and_ and wide version of the same.
| I can only say, that there maybe an identical wide one.
How is that reflectd with the precense of the wide parameter?
>> This patch does a lot more than what I am confortable with, it does
>> not just add the possibility of having floats in the layout file, or
>> letting the user create new floats.
>
>
| ???? for example ... ??
wide, caption etc.
>> That said, I really do like what the patch accompishes so I do want
>> it, just not in its present state. I'd like at least three different
>> patches:
>> - the .layout stuff and removal of hardcoded floats.
>> - gui for creation of new floats
>> - gui for modifing existing floats
>
>
| why different guis?
>
>> - gui for modifing specific floats
>
>
| what's this???
right click on a float to change "wide/non-wide", placement, the type,
etc.
>
>> - new float arguemtns/behaviour.
>
>> - the caption arg
>> - the wide arg
>> - etc.
>
>
| makes abosultely no sense. we have only one kind of
| floats and the only question is if it's a builtin
| or not.
then why is the wide parameter there?
>> (ok this is five (six).)
>> This makes also a lot easier to come with more nit-picking on details
>> (and yes there are a lot of small formatting mistakes, some wrong use
>> of references etc.)
>
>
| I can only do the first step, which was big enough and
>
| nobody can say that it doesn't work or break something
| and I wrote all my docs (books, article) with this
| floats.
| you can say, that there are too much nitpicking
| things in the code in fact of my poor c++ knowledge,
Or that you didn't adhere to the Rules and Recomendations.
| but when nobody does the first step, it will never be
| done.
The plan was never to do this for 1.2.0, in case you have forgot: we
stopped development to stabilize 1.2.0. 1.3.x is a different ballgame,
and has existed for 3 days. So your "...when nobody does the first
step..." is just mis-guided.
| And it's wrong when you say, that package floats
| are still supported, only a gui is missing.
You have not added any basic funtionallity in this patch, you add:
- floats in layout files
- gui for creation of new floats
- gui for setting options on floats
And this is bacsically what I have said is missing.
(and floats in layout files are not _really_ needed, but we want it
since that removes hard-coded stuff)
The patch is just to large as it is.
--
Lgb
