On Tue, Apr 30, 2002 at 05:32:27PM +0100, John Levon wrote:
>
> Looking at the patch I have a couple of minor comments ...
>
> + // check if the float type exist
> + if (argument == "figure") {
>
> I guess one day we will support floatingtable ??
Perhaps.
>
> { LFUN_INSET_FLOAT, "float-insert", "Insert a Float", Noop },
> { LFUN_INSET_WIDE_FLOAT, "float-wide-insert",
> "Insert a wide Float", Noop },
> + { LFUN_INSET_FLOATING, "floating-insert", "Insert a Floating", Noop },
> { LFUN_BOLD, "font-bold", N_("Toggle bold"), Noop },
>
> How come the 1st three of these aren't wrapped in N_() ?
The error was in the original code. I just copied the float line and changed
it...
> Also "Insert a Floating" doesn't make much sense. But I don't have
> a better suggestion right now
Does "Insert a Wrap" makes sense ?
I'm also want to change the names used in the code.
(for example, InsetWrap instead of InsetFloating).
> -#include "Floating.h"
> +//#include "Floating.h"
>
> Please always add a comment when you comment something out !!
I should have deleted it...
