John Levon <[EMAIL PROTECTED]> writes: | Load Intro.lyx and look at the "You tell LyX what you're doing". > | A fencepost error, but they accumulate in the saved version. > | The fix is attached. I don't know/care if it's right. > | thanks | john > | -- | I am a complete moron for forgetting about endianness. May I be | forever marked as such. > | Index: src/ChangeLog | =================================================================== | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v | retrieving revision 1.622 | diff -u -r1.622 ChangeLog | --- src/ChangeLog 13 Mar 2002 18:23:38 -0000 1.622 | +++ src/ChangeLog 13 Mar 2002 22:26:47 -0000 | @@ -1,3 +1,8 @@ | +2002-03-13 John Levon <[EMAIL PROTECTED]> | + | + * paragraph.C: fix fencepost error in getFontSettings() from | + last patch | + | 2002-03-13 Lars Gullik Bjønnes <[EMAIL PROTECTED]> | | * paragraph.C: change several algorithm to be more appripriate for | Index: src/paragraph.C | =================================================================== | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/paragraph.C,v | retrieving revision 1.197 | diff -u -r1.197 paragraph.C | --- src/paragraph.C 13 Mar 2002 18:23:37 -0000 1.197 | +++ src/paragraph.C 13 Mar 2002 22:26:51 -0000 | @@ -595,7 +595,7 @@ | Pimpl::FontList::const_iterator cit = pimpl_->fontlist.begin(); | Pimpl::FontList::const_iterator end = pimpl_->fontlist.end(); | for (; cit != end; ++cit) { | - if (cit->pos() > pos) | + if (cit->pos() >= pos) | break;
Ok then... are you sure? I can easily agree that this is the fix that we want. (it actually fits with what the old code did: pos < cit->pos() I think) This fix should be applied to all places where I did this change then. -- Lgb