On Tuesday 19 March 2002 4:49 pm, Jean-Marc Lasgouttes wrote: > >>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> On Tuesday 19 March 2002 4:09 pm, Jean-Marc Lasgouttes wrote: > >> >>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> JMarc, I have fixed things in my tree here so that this should > Angus> be pretty easy. All insets with dialogs are now derived from > > Angus> withDialog, so: > >> What about things like minipage? THey are both collabsable and > >> have a dialog, so we have too think about a reasonable interface. > > Angus> You have created an (LFUN_INSET_TOGGLE, toggle-inset) interface > Angus> that opens and closes collapsable insets. I suggest that we > Angus> leave this as-is and define a new (LFUN_INSET_DIALOG_TOGGLE, > Angus> toggle-inset-dialog) interface. > > what about inset-properties?
Good! Then the interface is to be: LFUN_INSET_PROPERTIES, inset-properties Inset::toggleDialog(BufferView *) {} InsetCommand::toggleDialog(BufferView * bv) { if (connected()) hideDialog(); else edit(bv, 0, 0, 0); } I'll code it up now. Angus