On Friday 22 February 2002 10:29 am, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | On Thursday 21 February 2002 7:08 pm, Michael Schmitt wrote: > >> Angus, > >> > >> why don't you just commit the patch to the head? People will complain > >> for a few days but Herbert has proven that committing things to the head > >> can speed up development significantly. And I remember you wanted to > >> release 1.2.0 soon... :-) > >> > >> Michael > > > | I think Lars should have the final say on that. > > > | Lars, what do you want me to do? > > This is soemthing that we want fixed before 1.2.0 right?
Yes > Is you partch "working" in your tree? Yes. Note that John can't link it. He gets an error in linking libsupport.o. Something to do with the forkedcontroller. I have no problems in this regard (using DEC cxx) and nor, it appears, has Dekel (using some version of gcc). So, the problem is probably trivial. > What is missing to have it "working"? Cropping, rotation and scaling of the image in LyX. Cropping and rotation are probably trivial (I'm trying to crop it now). I have no idea at all about scaling. Anyway, all the hooks are in place and the code "thinks" that the thing is cropped, scaled and rotated, so this is just a case of filling out some methods. The calls to current_view->updateInset(inset, false) from GraphicsCacheItem are ugly but wok for "simple" cases. The inset isn't displayed correctly if it's an inset in an inset, but Jürgen informs me that this is a fault with updateInset. I've put the patch at http://www.devel.lyx.org/~leeming/graphics.diff.bz2 It's 34725Bytes. Why don't you have a look at it/try and compile it? Angus
