On Tue, Feb 19, 2002 at 03:59:09PM +0000, Angus Leeming wrote:
> I'd like to commit the attached patch.
are you trying to confuse :)
+ if (pid<=0) { // Fork failed.
+ retval = 1;
please separate out the three cases after fork() !
as it is the comment is dead wrong
+ if (getpid() == 0) {
please don't (man getpid) - it's just confusing to use the
same name...
I suppose the timer polling is sensible enough assuming
we can't get xforms to tell us about SIGCHLD
regards
john
--
"They eat cold meat for breakfast and make jokes about gzip."
- Rik Hemsley on KDE developers
