On Saturday 05 January 2002 10:15 pm, you wrote:
>
> this fixes most of the cases, and asserts on the others
>
> please apply
>
> john
John,
I've just been perusing the FileInfo patch that you posted and that Jean-Marc
applied. The patched code results in:
Index: src/frontends/xforms/xforms_helpers.C, line 461:
FileInfo d(name);
// FIXME: what is this supposed to do ?
// .newFile doesn't do what you think it does ...
if (!d.isOK() || !d.isDir()) {
d.newFile(dir);
}
if (!d.isDir()) {
...
}
I'd guess that I wrote this code (a long, long time ago because I don't
remember newFile at all!) and so should probably answer you.
Can you tell me what newFile does? I've just looked quickly at the code in
FileInfo.C and it seems to me that newFile resets the FileInfo to examine
"dir" not "name". This, it seems, is exactly what I meant to do, all that
time ago, so I don't follow your FIXME comment. In fairness, I think that the
final line of code above should also have an isOK() check too but you seem
pretty knowledgable on all this.
Insight is, as always, appreciated.
Angus
