On Wed, Jan 02, 2002 at 02:36:48PM +0100, Juergen Vigna wrote:
> > is never called when doing some 'find' using the menu. Do I need some more
> > activation magic?
> 
> Well yes you need this in formulabase.h
> 
> ///    
> // it has to contain text to be searchable!
> ///
> bool isTextInset() const { return true; }

What about some 'isSearchableInset' method? I do not want to pretend being
a text inset...

> The normal text has to lock the inset (by calling edit()) before the
> searchForward() is being called. Then if we find something we return
> true (and if appropriate set the selection), if we don't find something
> we have to unlock ourself (the inset) and return false!
> 
> Logic to be (IMO):
> 
> The normal text comes to an inset and searchForward() of the inset is called.
> Now the inset is resposible to lock itself and do all necessary update steps
> if it finds something inside otherwise it just returns false and we're done
> with it.

Yes, sounds better.

> Now to anticipate your upcoming questions:
> 
> Q: Why has this not be done before?
> A: The (un)lock calls of the inset have been made more inteligen recently by
>    me, NOW it is possible to call a lock inset from within a subinset without
>    the need of having the outer inset already locked, this was not possible
>    before.

I see.

> Q: Why then not change now to the new method?
> A: We have still a lot of bugs to fix and IMO we should concentrate on that
>    right now.

Fine with me.

BTW: It seems to work. But it's tea time now...

Andre'

-- 
Andr� P�nitz .............................................. [EMAIL PROTECTED]

Reply via email to