>>>>> "John" == John Levon <[EMAIL PROTECTED]> writes:

John> On Wed, Dec 12, 2001 at 11:02:55AM +0100, Jean-Marc Lasgouttes
John> wrote:
Andre> On Tue, Dec 11, 2001 at 11:16:58AM +0100, Andre Poenitz wrote:
Andre> Hmpf... of course I meant just the chunk in lyxfind.C:
>>  John, could you have a look at that?

John> sorry, missed the original - what's the problem ?

Uniniitialized variable:

Index: lyxfind.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfind.C,v
retrieving revision 1.20
diff -u -p -r1.20 lyxfind.C
--- lyxfind.C   2001/12/10 12:50:08     1.20
+++ lyxfind.C   2001/12/11 10:16:56
@@ -225,7 +225,7 @@ SearchResult SearchForward(BufferView * 
        Paragraph * par = text->cursor.par();
        pos_type pos = text->cursor.pos();
        Paragraph * prev_par = par;
-       pos_type prev_pos;
+       pos_type prev_pos = 0;
        UpdatableInset * inset;
 
        while (par && !IsStringInText(par, pos, str, cs, mw)) {

I do not understand the code, so you're the one who can say what the
good default value is.


>> if (pos >= par->size()) { prev_par = par; // consider 0-sized empty
>> pars prev_pos = par->size();

John> uh, yeah, I think so - it must have been left in from a previous
John> attempt to do it slightly differently. So I don't think we need
John> prev_pos at all, we can always do prev_par->size() in the
John> setCursor call on fail case.

Could you do that?

JMarc

Reply via email to