On Mon, Dec 03, 2001 at 11:29:31AM +0100, Juergen Vigna wrote:
>
> On 01-Dec-2001 John Levon wrote:
> >
> > I think this patch is correct and the old code was wrong. An explanation
> > is in the ChangeLog.
> >
> > After Juergen/Lars/someone checks it, please apply !
>
> I feel that this is not the right fix. You may be right that we have to fix
> something there but your's just doesn't seem right. Please tell me where do
> you see problems and what this patch does fix. Maybe we'll find a better/right
> way to do this then!
OK, here's my reading :
An inset needs updating. The bv has a locking inset: this means it is the responsibilty
of the locking inset to perform the update, if the inset is inside the locked inset.
So we pass the demand for updating the inset down to insettext. Now insettext (from
inside
the figure float) effectively says "well no insets inside of me are locked - that means
I don't know how to update the inset".
But what insettext is saying is wrong - it DOES know how to update inset because
the insetgraphics is a member of that insettext. Just because it hasn't locked inside
the insettext (i.e. is not InsetText::the_locking_inset) doesn't mean it doesn't need
updating.
Basically, insettext is refusing to update its "children" unless they have locked
themselves, which never happens for insets like insetgraphics.
Instead, it should honour the update request whenever the inset is inside ...
Which part of this is wrong ? What's the alternative method ?
regards
john
--
"Faced with the prospect of rereading this book, I would rather have
my brains ripped out by a plastic fork."
- Charles Cooper on "Business at the Speed of Thought"
