On Fri, Nov 23, 2001 at 09:46:58AM +0100, Lars Gullik Bjønnes wrote:
> I am not quite sure about this int->kb_action change.
>
> a pseudo action is not really part of the kb_action enum, so I am not
> sure if it is correct to do this.
/me nods. I'd not considered it like that... it is still perhaps a little more
readable than "int" as long as we bear in mind that it might not be one of
the kb_action enum values ...
> | - Sectioning.h \
> | - Sectioning.C \
> | ShareContainer.h \
>
> Have you checked that rpm building still works?
You mean we're not using autopack yet ?!
I suppose the source goes in EXTRA_DIST or something to get RPM OK with it ?
> | + case 0x0: // latin 1
> | return c;
> | - // latin 2 byte 3 = 1
>
> Not quite sure if I like what you do here. There is a reason why the
> hex is written as it is: make the number of bytes very explicit and
> match it to the comments in keysymdef.h.
what is keysymdef.h ? (not really bothered about this one ...)
> | - // 0.12 this will be way to early, we need the GUI to be initialized
> | - // first, so move it for now.
> | - // lyxserver = new LyXServer;
> | }
>
> why remove this comment? How will we now remember that the LyXServer
> is supposed to be run from approx. this point?
I suppose so ... I just feel like an archaelogist with all these 0.12, 0.13 references
john
--
"By the way, it's not binaries, it's Perl code. Sometimes they look confusingly
similar."
- Pavel Roskin
