On Thu, Nov 22, 2001 at 10:14:48AM +0100, Jean-Marc Lasgouttes wrote:

> Lars> Patch looks ok to me. Where is isMetaInset used now?
> 
> I guess it should not be used anymore.

doesn't the patch remove it ? I must admit I'd not noticed para->isInset(pos)
before doing the earlier patch (since only a few places used it before)

> par-> isInset(....) && par->getInset(...) && par->getInset(...)->XXX
> 
> Lars> was used, is the par->getInset(...) needed there? (it would be a
> Lars> blatant bug if isInset returns true and getInset return NULL...)
> 
> Maybe isInset should assert on the value of the inset pointer?

see my other mail I asked the exact same question :)

How about we experiment with an assert in getInset() (where we currently have
a little discussion about ' ') ?

> John, do you want me to apply this?

please

thanks
john

-- 
"Your superior intellect is no match for our puny weapons."

Reply via email to