>>>>> "Michael" == Michael Koziarski <[EMAIL PROTECTED]> writes:

>> no!
>> 
>> from my point of view, we can also get rif of these
>> 
>> features["graphicx"] = false; features["setspace"] = false;
>> features["makeidx"] = false; features["verbatim"] = false;
>> 
>> if we choose a list and save only the used packages


Michael> This patch uses a list instead of a map. I've also wrapped up
Michael> all of the member variables except for vector<bool> layout;

This seems very good to me. Although it is not caused by your patch,
it strikes as odd to see the following code in buffer.C:
-               if (features.amsstyle
+               if (features.isRequired("amsstyle")
                    && !tclass.provides(LyXTextClass::amsmath)) {
                        ofs << "\\usepackage{amsmath}\n";
                        texrow.newline();

Would it be possible to move this in LaTeXFeatures?

JMarc

Reply via email to