Michael Schmitt wrote:
> Yes, the field should be renamed to "Longest Label", "Label Text", or
> something similar.
> While we are discussing the "Paragraph Layout" dialog: Shouldn't we
> remove "General" or do you intend to add further "pages" to the
> dialog?
This has been done in CVS!
> Moreover, "Label width" or whatever it will be called in the
> future should be placed in a box like all other fields.
Agreed. The attached patch does this. It renames "Label Width" to
"Longest Label" (I'm not shure if this is correct English and good
style, though) and adds a framebox "Label Width" (so the docs don't
have to be changed ;-)), which looks indeed cleaner (IMHO). If people
like it...
> And finally,
> it is possible to edit the field even if it is "Senseless with this
> layout!". In other dialogs, such fields are disabled in that case.
Agreed. I don't know how to do this, though :-(
Thanks,
Jürgen
> Michael
Index: src/frontends/xforms/ChangeLog
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/ChangeLog,v
retrieving revision 1.152
diff -u -r1.152 ChangeLog
--- src/frontends/xforms/ChangeLog 2001/09/07 17:55:37 1.152
+++ src/frontends/xforms/ChangeLog 2001/09/08 17:36:10
@@ -1,3 +1,8 @@
+2001-09-08 Jürgen Spitzmüller <[EMAIL PROTECTED]>
+
+ * forms/form_paragraph.fd: cosmetics (renamed "Label Width" to "Longest
+ Label", added a labelframe).
+
2001-09-07 Angus Leeming <[EMAIL PROTECTED]>
* FormBaseDeprecated.[Ch]: use the same allow_resize methodology as has
Index: src/frontends/xforms/form_paragraph.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/form_paragraph.C,v
retrieving revision 1.12
diff -u -r1.12 form_paragraph.C
--- src/frontends/xforms/form_paragraph.C 2001/08/29 12:52:41 1.12
+++ src/frontends/xforms/form_paragraph.C 2001/09/08 17:36:11
@@ -141,9 +141,12 @@
fl_set_object_callback(obj, C_FormBaseDeprecatedInputCB, 0);
fdui->input_linespacing = obj = fl_add_input(FL_NORMAL_INPUT, 380, 185, 100, 30, "");
fl_set_object_callback(obj, C_FormBaseDeprecatedInputCB, 0);
+ obj = fl_add_labelframe(FL_ENGRAVED_FRAME, 10, 245, 350, 45, _("Label Width"));
+ fl_set_object_lsize(obj, FL_NORMAL_SIZE);
+ fl_set_object_lstyle(obj, FL_BOLD_STYLE);
{
- char const * const dummy = N_("Label Width:|#d");
- fdui->input_labelwidth = obj = fl_add_input(FL_NORMAL_INPUT, 125, 250, 235, 30, idex(_(dummy)));
+ char const * const dummy = N_("Longest Label:|#g");
+ fdui->input_labelwidth = obj = fl_add_input(FL_NORMAL_INPUT, 125, 255, 230, 30, idex(_(dummy)));
fl_set_button_shortcut(obj, scex(_(dummy)), 1);
}
fl_set_object_lsize(obj, FL_NORMAL_SIZE);
@@ -155,7 +158,7 @@
fl_set_object_lstyle(obj, FL_BOLD_STYLE);
{
char const * const dummy = N_("No Indent|#I");
- fdui->check_noindent = obj = fl_add_checkbutton(FL_PUSH_BUTTON, 375, 250, 115, 30, idex(_(dummy)));
+ fdui->check_noindent = obj = fl_add_checkbutton(FL_PUSH_BUTTON, 375, 255, 115, 30, idex(_(dummy)));
fl_set_button_shortcut(obj, scex(_(dummy)), 1);
}
fl_set_object_lsize(obj, FL_NORMAL_SIZE);
Index: src/frontends/xforms/forms/form_paragraph.fd
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/forms/form_paragraph.fd,v
retrieving revision 1.10
diff -u -r1.10 form_paragraph.fd
--- src/frontends/xforms/forms/form_paragraph.fd 2001/08/29 12:52:41 1.10
+++ src/frontends/xforms/forms/form_paragraph.fd 2001/09/08 17:36:12
@@ -11,7 +11,7 @@
Name: form_paragraph
Width: 500
Height: 395
-Number of Objects: 33
+Number of Objects: 34
--------------------
class: FL_BOX
@@ -446,16 +446,34 @@
argument: 0
--------------------
+class: FL_LABELFRAME
+type: ENGRAVED_FRAME
+box: 10 245 350 45
+boxtype: FL_NO_BOX
+colors: FL_BLACK FL_COL1
+alignment: FL_ALIGN_TOP_LEFT
+style: FL_BOLD_STYLE
+size: FL_NORMAL_SIZE
+lcol: FL_BLACK
+label: Label Width
+shortcut:
+resize: FL_RESIZE_ALL
+gravity: FL_NoGravity FL_NoGravity
+name:
+callback:
+argument:
+
+--------------------
class: FL_INPUT
type: NORMAL_INPUT
-box: 125 250 235 30
+box: 125 255 230 30
boxtype: FL_DOWN_BOX
colors: FL_COL1 FL_MCOL
alignment: FL_ALIGN_LEFT
style: FL_NORMAL_STYLE
size: FL_NORMAL_SIZE
lcol: FL_BLACK
-label: Label Width:|#d
+label: Longest Label:|#g
shortcut:
resize: FL_RESIZE_X
gravity: FL_West FL_East
@@ -484,7 +502,7 @@
--------------------
class: FL_CHECKBUTTON
type: PUSH_BUTTON
-box: 375 250 115 30
+box: 375 255 115 30
boxtype: FL_NO_BOX
colors: FL_COL1 FL_YELLOW
alignment: FL_ALIGN_CENTER
