On Fri, Jul 27, 2001 at 02:15:56PM +0200, Jean-Marc Lasgouttes wrote:
> Dekel> Why the language in insetERT is changed to ignore_language ???
>
> We need a way to say inherit language. This works well for everything
> in a font when one specifies ALL_INHERIT, _except_ for language. Why?
Because the language property is not inherited.
If you write some text in an English document, and then copy it to a French
document, the language of the text should remain English (there are
exceptions if for example you copy source code).
> Dekel> The correct way for implementing insetERT is to have an
> Dekel> InsetEditor and use it instead of insetText. Currently, I think
> Dekel> that the cleanest solution is to set the language inside
> Dekel> inserERT to the language of the document.
>
> No, we need an inherit setting for language, but since we do not have
> a "default" language anymore, it seemed that ignore was right.
> However the code in lyxfont probably has to be teaked to handle that.
We didn't need inherit language before, so we don't need one now.
You only want to set some language for the text in insetert, and I think
that the cleanest way is to use the document language (you won't need to
change lyxfont.C).
> Dekel> Also, when converting the old insetInfo to an insetNote, the
> Dekel> language in the inset should be set to the language of the
> Dekel> document (or maybe to the language of current paragraph ??),
> Dekel> except when that language is a RTL language (Hebrew/Arabic),
> Dekel> and in that case the language should be set to English.
>
> No, the language should be transparent in some way. And having special
What do you mean by transparent ?
> BTW, Dekel, what is the reason why there are plenty comparison of
> language to "hebrew" in the code? Shouldn't these places test for RTL
> instead? Such hardcoding is a bit wrong IMO.
We only support Hebrew and Arabic, and the Arabic support is a little
different as Arabtex doesn't use babel.
I guess that instead of checking whether language->lang() == "hebrew"
we should do 'language->rtl() && !using_arabtex).
I'll look into it when I find some spare time...
