On Sun, 22 Jul 2001, John Levon wrote:

> On Thu, Jul 19, 2001 at 05:01:44PM +1000, Allan Rae wrote:
[...]
> > Talking about coding rather than user input.  IMO, these fields of the
> > dialog shouldn't be going anywhere near the input() function.
>
> the problem is here :
>
>     352         if (ob->form->fdui == colors_.dialog()) {
>     353                 colors_.input(ob);
>     354                 return true;
>
> in ::input(), so we always validate there.
>
> I suppose you want all the color widgets to not go via InputCB ?

AFAICS, the only button on the colour tabfolder that should trigger the
input validation is the "Modify" button.  Since the user can only enter a
valid colour (due to the restrictions of the colour bars/wheel) then the
validation test for the colour area is always true (and could be left out
if validity is the default assumption) _but_ it is there to cause a
transition in the state machine.

Allan. (ARRae)

Reply via email to