On Mon, Mar 24, 2025 at 04:11:50PM +0100, Thibaut Cuvelier wrote: > On Sun, 23 Mar 2025 at 12:32, Scott Kostyshak <skost...@lyx.org> wrote: > > > On Sat, Mar 22, 2025 at 11:29:45PM +0100, Thibaut Cuvelier wrote: > > > On Mon, 10 Feb 2025 at 15:28, Scott Kostyshak <skost...@lyx.org> wrote: > > > > > > > On Mon, Feb 10, 2025 at 03:11:45PM +0100, Thibaut Cuvelier wrote: > > > > > On Mon, 10 Feb 2025 at 11:17, Scott Kostyshak <skost...@lyx.org> > > wrote: > > > > > > > > > > > On Sun, Feb 09, 2025 at 12:37:18AM +0100, Scott Kostyshak wrote: > > > > > > > The following ctests are failing for me: > > > > > > > > > > > > > > > > > > > > ... > > > > > > > > > > > > Thibaut, do you think these can be related to your recent work? > > Can you > > > > > > reproduce the test failures? > > > > > > > > > > > > > > > I can reproduce locally at 7606da5e, bbb79522, and f70409b3. I > > believe > > > > it's > > > > > one commit near f70409b3 that created that problem, > > > > > > > > Thanks a lot for confirming you can reproduce and taking a look! > > > > > > > > > I could confirm that f70409b3 is indeed the culprit. A symptom of having > > > \text converted to garbled <mtext> is not due to a change in > > InsetMathFont, > > > but rather in MathStream (there is no related change near InsetMathFont). > > > That leaves off 7.42% of this commit 😅. More precisely, it's in lines > > > 679-705 of MathStream.cpp (as of f70409b3) or code called from there. > > > > > > In the end, the bug (or, at least, a bug) is when calling the docstring > > > constructor to have a string of one character: I inverted the two > > > arguments. Quite silly! > > > > > > I have pushed two patches that solve this problem > > > (eab73de5f134930c84bb75d78c9aa8b91558b418 and > > > 2e12882ec6fbf37c0480e98099f01fa355f45bc0). > > > > Thanks for the fixes! I've unignored the xhtml tests at 271b9c2d. Now > > you have to do a fresh build (or at least rerun your 'cmake' command > > from the build directory). Your commit fixed a lot of tests. Now only > > the following ones are failing for me: > > > > 1989 - export/doc/Math_xhtml (Failed) > > 2051 - export/doc/UserGuide_xhtml (Failed) > > 2100 - export/doc/ar/UserGuide_xhtml (Failed) > > 2319 - export/doc/de/Math_xhtml (Failed) > > 2376 - export/doc/de/UserGuide_xhtml (Failed) > > 2547 - export/doc/es/Math_xhtml (Failed) > > 2604 - export/doc/es/UserGuide_xhtml (Failed) > > 2794 - export/doc/fr/Math_xhtml (Failed) > > 2851 - export/doc/fr/UserGuide_xhtml (Failed) > > 3199 - export/doc/ja/Math_xhtml (Failed) > > 3244 - export/doc/ja/UserGuide_xhtml (Failed) > > 3506 - export/doc/ru/Math_xhtml (Failed) > > 3563 - export/doc/ru/UserGuide_xhtml (Failed) > > 4187 - export/examples/Graphics_and_Insets/XY-Pic_xhtml (Failed) > > 5637 - export/examples/fr/Graphics_and_Insets/XY-Pic_xhtml (Failed) > > 6515 - export/examples/ru/Graphics_and_Insets/XY-Pic_xhtml (Failed) > > > I have fixed a few more bugs, now, Math should pass (and possibly others). > In particular, I fixed a few issues that were present in LyX 2.4. I think > that 922c8107 should make it into 2.4.
Thanks, Thibaut. The tests all pass now! Thanks for your work. It looks like you worked around a bunch of tricky issues. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
