Am Mon, 17 Mar 2025 23:27:09 +0100 schrieb Pavel Sanda <sa...@lyx.org>:
...
> BTW Kornel, when I tried to test this in master, it seems that Adv Find is
> broken there.
> If I just follow steps in MWE of the bug above the search errorneously
> triggers
> the dialog of reach end of document, although it should just land on the
> first
> occurence. Can you check?
>
> Pavel
I have no idea. Bisect leads to
commit 9c443d96
Author: Jean-Marc Lasgouttes <lasgout...@lyx.org>
AuthorDate: Wed Sep 4 15:48:38 2024 +0200
Commit: Jean-Marc Lasgouttes <lasgout...@lyx.org>
CommitDate: Thu Sep 5 16:57:35 2024 +0200
Cleanup Page Up/Down code
Since BufferView::scroll() does not correct scrolling amount at
top/bottom anymore, remove its return value and add a new one to
BufferView::updateMetrics(bool) that returns this correction.
Rely on updateMetrics(false) to set the metrics straight after moving
the anchor y position.
Use assert_in_view = false when calling TextMetrics::editXY() because
this parameter does not work as advertised: if an inset not totally
visible, the code will not try to go inside it to look for a smaller
row that is totally visible.
Two small (hopfully useful) modifications:
- take into account the cursor X target instead of its screen position
- adapt the cursor position depending on
lyxrc.mac_like_cursor_movement when hitting start or end of
document.
src/BufferView.cpp
src/BufferView.h
Kornel
pgpwmCRVNTdRw.pgp
Description: Digitale Signatur von OpenPGP
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
