On Sun, Mar 09, 2025 at 07:09:01PM +0100, Jean-Marc Lasgouttes wrote:
> Le 09/03/2025 à 18:23, Jean-Marc Lasgouttes a écrit :
> > I do not have much time right now, but hotspot thinks that the time is
> > spent in BulletsModule constructor.
> > 
> > This code uses svg images since the commit below. Would it be faster
> > with one big svg for each type of bullets ?
> > 
> > With 2.5, this is dwarfed by ColorCombo, but that is a different story.
> 
> Using pmprof on master with the attached patch, one sees indeed that bullets
> and colors use 94% of GuiDocument creation time.
> 
> #pmprof# bulletsModule: 432.70 ms, count=1, total=432.70 ms
> #pmprof# colorModule: 884.27 ms, count=1, total=884.27 ms
> #pmprof# GuiDocument: 1.40 s, count=1, total=1.40 s
> 
> What is strange though is that the dialog seems to need more than 1.4
> seconds to appear, but this is subjective.
> 
> Note that the ColorsCombo thing also costs time in other places, the total
> cost of fillComboColor is 1.24 seconds in 21 calls.

Thanks for the patch!

I have similar stats:

#pmprof# bulletsModule: 313.96 ms, count=1, total=313.96 ms
#pmprof# colorModule: 931.35 ms, count=1, total=931.35 ms
#pmprof# GuiDocument: 1.29 s, count=1, total=1.29 s

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to