On Tue, Jun 28, 2022 at 09:45:24AM GMT, Pavel Sanda wrote:
> commit 6874c86cb58f4387734c97423bfe9a60cbaec247
> Author: Pavel Sanda <sa...@lyx.org>
> Date:   Tue Jun 28 10:26:42 2022 +0200
> 
>     Fix gcc 13 compilation.
>     
>     Spotted by Jose.
> ---
>  src/tex2lyx/Parser.cpp |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/tex2lyx/Parser.cpp b/src/tex2lyx/Parser.cpp
> index e4eb9b4..2fd1789 100644
> --- a/src/tex2lyx/Parser.cpp
> +++ b/src/tex2lyx/Parser.cpp
> @@ -16,6 +16,7 @@
>  #include "support/lstrings.h"
>  #include "support/textutils.h"
>  
> +#include <cstdint>
>  #include <iostream>
>  
>  using namespace std;
> -- 

Note to others and myself: it's helpful if you put the compiler error in
the commit message. The reason is that I often want to cherry-pick this
commit when bisecting LyX (at a point in history before the fix).

Before I could do my bisect of interest (which happened to be for
https://www.lyx.org/trac/ticket/13116) I first had to do a bisect to
figure out which commit fixes GCC compilation. I would have found it
helpful if you put the compilation error in the commit message because
then I could have just searched the git log for "uint32_t".

I know that the error might be specific to the compiler (e.g., GCC vs.
Clang) but stil that would give me a chance.

Would there have been any easier way to find that this commit is the one
I needed to fix the compilation error? Or any GCC/Clang flag I can turn
on to try to be compatible with older versions of code? I did not
actually try -std=c++14 or something like that; maybe it would have
worked.

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to