On Sun, Sep 22, 2024 at 10:23:36AM GMT, Kornel Benko wrote:
> Am Thu, 19 Sep 2024 22:46:36 +0200
> schrieb Scott Kostyshak <skost...@lyx.org>:
> 
> > On Wed, Sep 18, 2024 at 11:42:34AM GMT, Scott Kostyshak wrote:
> > > On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote:  
> > 
> > > > But now using pdf your patch makes more sense.  
> > > 
> > > Sounds good. I'll apply it.  
> > 
> > Done at c7be9780.
> > 
> > > First I will see if any new tests fail with
> > > it though.  
> > 
> > These tests fail for me now:
> > 
> >   export/doc/ja/UserGuide_lyx16
> >   export/doc/ja/UserGuide_lyx20
> >   export/examples/ja/Modules/LilyPond_Book_lyx16
> >   export/examples/ja/Modules/LilyPond_Book_lyx20
> > 
> > But it's not clear it's worth the time to fix them so I inverted them at
> > 92c7c33d.
> > 
> > Scott
> 
> With the attached (tested -R lyx20), I get
> 99% tests passed, 1 tests failed out of 381
> 
> 3689 - INVERTED.TODO_export/examples/Articles/Chess/Game_1_lyx20 (Failed)

Looks very nice, thanks! I had wondered how to return/read multiple
values using CMake. Your solution of regex-splitting on "/" seems simple
and good for this case (i.e., I cannot imagine a format that uses '/' in
its name and I'm sure that would break other things as well).

I would say +1 to commit. I can run the full set of ctests after you
commit in the next days.

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to