On Thu, Aug 29, 2024 at 11:34:57AM +0200, Jean-Marc Lasgouttes wrote:
Le 28/08/2024 à 20:51, Enrico Forestieri a écrit :
I am not sure I understand your concern. That makes the -geometry option work also on Windows. Maybe those lines can be transferred in the following guard, i.e.,

I propose a more radical approach, which is to change -geometry to -windowgeometry on all platforms. This means that -geometry is now supported everywhere.

Fine.

What I did not do is remove the hand-made parsing of geometry that is used for window-new lfun only on Windows (why?). Can this go away?

That code was necessary for Qt4, where -qwindowgeometry was not available. It was necessary on Windows because the backend did not support -geometry and we had to parse it by ourselves. When an option is supported by the backend, it is automatically removed. This is now the case with -qwindowgeometry, so that this code can now go away.

The second patch gets rid of QPA_XCB and replaces it with a runtime decision depending on current platform. In theory, this would allow for cocoa/xcb or win32/xcb binaries (like we have xcb/wayland binaries), with some extra work of course.

Fine.

--
Enrico
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to