On Sun, Oct 08, 2023 at 10:11:58PM +0200, Thibaut Cuvelier wrote: > On Sun, 8 Oct 2023 at 21:35, Thibaut Cuvelier <dourou...@gmail.com> wrote: > > > On Sun, 8 Oct 2023 at 17:05, Scott Kostyshak <skost...@lyx.org> wrote: > > > >> On Sun, Oct 08, 2023 at 02:48:45PM +0200, Thibaut Cuvelier wrote: > >> > Just a quick amendment to a previous patch (#1 in the series): there > >> was a > >> > quite big typo there... It should solve the largest issue with the newly > >> > failing test, but not all. I'm having a look at this test to improve the > >> > situation a bit more. > >> > > >> > Thibaut Cuvelier > >> > >> Sounds good. Riki OK to commit these to master? > >> > > > > I've taken some time to solve the issue with that test. I am adding one > > more patch to the list to solve it, plus another one to fix a crash I > > noticed while debugging this example. > > > > (FYI, the patch #4 in the sequence is a cleanup I made while having a look > > at https://www.lyx.org/trac/ticket/12891.) > > > > I took the time to do the XHTML version too. It's almost the same code, > again without touching anything about LaTeX.
I just went ahead and committed since (1) the tests look, (2) you try not to touch non-DocBook code, and (3) we haven't had a freeze yet. Committed to master starting at 0c2f3ded. Thanks for your work on these patches. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
