Le 30/09/2023 à 15:23, Jürgen Spitzmüller a écrit :
Am Freitag, dem 29.09.2023 um 15:53 +0200 schrieb Jürgen Spitzmüller:
And it only works for fully selected math insets, not for parts of
it. Don't know where to set the latter.

The issue here is, probably, that Math is missing something like
RowPainter::paintStringAndSel() which accounts for, and colors, partial
selections of text. Probably a bit more work to implement this, but it
would also be needed to draw change tracking marks in math.

I implemented the color change for local math selections. I notice right now that I missed the case of multiple cell selection. I'll have a look.

I still think the patch should go in, as it cures at least one half of
the problem.

Note that currently, with "use system colors", we have the same half-
solution only (and a similar contrast problem even in light mode, as
the attached screenshot from stable demonstrates).

So I would have to put your patch on top of that, and probably manage to remove the test for use_system_colors in mathed. This test does not make sense anyway, we should always use Color_selection*.

What I do not understand, though, is why you have to go through all these hoops instead of picking a good color for selected math text in dark mode.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to