On Sat, Sep 30, 2023 at 9:36 PM Scott Kostyshak <skost...@lyx.org> wrote:
>
> The list of ctests below fail for me due to a recent commit. I don't
> currently have time to look into them. If no one gets to it before, I
> can take a look next week.
>
>   DEFAULTOUTPUT_export/export/latex/inputenc-utf8-platex_pdf (Failed)
>   export/export/latex/inputenc-utf8-platex_pdf3 (Failed)

This one is probably my fault:
https://www.lyx.org/trac/changeset/48eda746dabecf100bd163b822ed9db68ab9eb3f/lyxgit
I actually tested platex before changing that, not sure what is going
on with this particular
document, it claims David CLM does not contain hebrew punctuation.
Let's just drop the change
in platex export until 2.4 will be released.

>   export/templates/Articles/IEEE_Transactions_Computer_Society_lyx22 (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_lyx23 (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_dvi (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_dvi3_texF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_dvi3_systemF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf2 (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf3 (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf4_systemF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf5_texF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_Computer_Society_pdf5_systemF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_lyx22 (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_lyx23 (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_dvi (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_dvi3_texF (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_dvi3_systemF (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf2 (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf3 (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf4_systemF (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf5_texF (Failed)
>   export/templates/Articles/IEEE_Transactions_Journal_pdf5_systemF (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_lyx22 (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_lyx23 (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_dvi (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_dvi3_texF (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_dvi3_systemF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf2 (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf3 (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf4_systemF 
> (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf5_texF (Failed)
>   export/templates/Articles/IEEE_Transactions_on_Magnetics_pdf5_systemF 
> (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_lyx22 (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_lyx23 (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_dvi (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_dvi3_texF (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_dvi3_systemF (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf2 (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf3 (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf4_systemF (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf5_texF (Failed)
>   export/templates/Articles/REVTeX_%28V._4.1%29_pdf5_systemF (Failed)
>   export/templates/Posters/A0_Poster/Simple_lyx22 (Failed)
>   export/templates/Posters/A0_Poster/Simple_lyx23 (Failed)
>   export/templates/Posters/A0_Poster/Simple_dvi (Failed)
>   export/templates/Posters/A0_Poster/Simple_dvi3_texF (Failed)
>   export/templates/Posters/A0_Poster/Simple_dvi3_systemF (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf2 (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf3 (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf4_systemF (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf5_texF (Failed)
>   export/templates/Posters/A0_Poster/Simple_pdf5_systemF (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_lyx22 (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_lyx23 (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_dvi (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_dvi3_texF (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_dvi3_systemF (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf2 (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf3 (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf4_systemF (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf5_texF (Failed)
>   export/templates/Theses/PhD_Thesis/Main_File_pdf5_systemF (Failed)

I think the culprit for these is:
https://www.lyx.org/trac/changeset/087f6bce71dc6d164bccaa49461d17338e7d6c4e/lyxgit
There is a missing validation for the requirement of xcolor in
InsetBox::validate, the case we use Boxed with non-default color.
Please try the attached patch (Jürgen, can you review it and check if
I'm correct about the part in InsetBox.cpp?).

Best regards,
Udi

> Scott
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
diff --git a/src/Encoding.cpp b/src/Encoding.cpp
index dc84192471..dab24b72dd 100644
--- a/src/Encoding.cpp
+++ b/src/Encoding.cpp
@@ -204,7 +204,7 @@ bool Encoding::encodable(char_type c) const
 		return true;
 	// platex does not load inputenc: force conversion of supported characters
 	if (package_ == Encoding::japanese
-	    && ((0xb7 <= c && c <= 0x058f) // Latin-1 Supplement ... Armenian
+	    && ((0xb7 <= c && c <= 0x05ff) // Latin-1 Supplement ... Hebrew
 			|| (0x1d00 <= c && c <= 0x218f) // Phonetic Extensions ... Number Forms
 			|| (0x2193 <= c && c <= 0x2aff) // Arrows ... Supplemental Mathematical Operators
 			|| (0xfb00 <= c && c <= 0xfb4f) // Alphabetic Presentation Forms
diff --git a/src/insets/InsetBox.cpp b/src/insets/InsetBox.cpp
index 36507cf8e2..81506be6da 100644
--- a/src/insets/InsetBox.cpp
+++ b/src/insets/InsetBox.cpp
@@ -810,7 +810,7 @@ void InsetBox::validate(LaTeXFeatures & features) const
 		break;
 	case Boxed:
 		features.require("calc");
-		if (getFrameColor() != "black" || getBackgroundColor() != "white")
+		if (getFrameColor() != "default" || getBackgroundColor() != "white")
 			features.require("xcolor");
 		break;
 	case ovalbox:
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to