Juergen Vigna <[EMAIL PROTECTED]> writes:

| On 07-May-2001 Lars Gullik Bjønnes wrote:
| 
| > (this patch started with the TextContainer... then NO_NEXT was added
| > ... eventually removal of LyXParagraph::Clone... if I can't find out
| > what is happening I will begin to feed it to cvs is small (non-buggy)
| > batches.)
| 
| Well Lars I had a fast look and it seems to me the assignment of the
| inset in the TextContainer is strange (did you think of the Undo
| handling?).

I don't think undo handling comes into play here, but I managed to fix
the huge bug.

I will apply this patch piece by piece.

| Then you just do too much in one step. Why not just first do all the changes
| you did in changing string to osstream and then get the textcontainer so
| it would be really easier to see what you're really doing.
| 
| One more thing I saw. You added #includes to .h files without changing
| anything in that .h file. It seems strange to me and we should try to
| minimize including files in .h files, don't you think so?

did you also see that I removed #includes from other files? en effect
of this is that the same include files removed from .h files need to
be added to some .C files.

-- 
        Lgb

Reply via email to