On Sat, Dec 31, 2022 at 3:00 AM Thibaut Cuvelier <dourou...@gmail.com> wrote:
> I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I > hope I didn't make too many mistakes. I'm also attaching the patch to this > email so that you can check it more easily if you want. > > Hi Thibaut Cuvelier, thank you for the patch. After browsing LyX's bug tracker in the past few weeks, i now realize that some of the changes i've made on the subject discussed in this thread <https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218016.html> will break backward compatibility and and will produce undesirable export to TeX code (one that works, for example, the syntax won't be supported by IDEs). I will send today a patch regarding only the new module so it will be easier to test it. > (If someone can add Udi to the blanket permissions, here is the link on > the mailing list: https://marc.info/?l=lyx-devel&m=165779733507955&w=2) > > Thibaut Cuvelier > > > On Sat, 31 Dec 2022 at 01:00, Thibaut Cuvelier <dourou...@gmail.com> > wrote: > >> Hi, >> >> I'm jumping back in this discussion. There have been recent changes in >> the DocBook implementation of theorems. Instead of setting DocBookTag and >> DocBookAttr like this: >> >> DocBookTag para >> DocBookAttr role='theorem' >> >> we now use a wrapper to delimit theorems: >> >> DocBookWrapperTag figure >> DocBookWrapperAttr role='theorem' >> DocBookTag para >> DocBookGenerateTitle true >> >> For your other theorems, just update the line role= with the right kind >> of element (just like on master). I can take care of this step when merging >> your patch, as there seems to be some consensus around it. >> >> I noticed you asked whether anything was required for lists of theorems >> and the list: no, the DocBook processor is supposed to take care of that. >> >> As you gave permission to use your patch under the GPL in an earlier >> message (why isn't it listed on https://www.lyx.org/BlanketPermission?), >> I'm proceeding with integrating your patch :). >> >> All the best, >> Thibaut Cuvelier >> >> I will add these changes to the new patch. Best Regards, Udi
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
