On Mon, Aug 08, 2022 at 04:46:54PM +0200, Stephan Witt wrote: > 1) > AFAICS the synctex activation is possible for more than pfdlatex output only. > I???ve tried dvi, luatex and xetex and all of them work for me. So I???ve > changed the check in BufferParams::writeLaTeX to use OutputParams::isLaTeX. > Is someone to tell if this change is the right one? Perhaps it???s > superfluous in BufferParams::writeLaTeX at all and one can output it w/o the > check for the flavor here?
This is very long time ago and my memory might be failing, but I think the disctinction between srcltx vs synctex was there because srcltx was working for dvi. So perhaps enabling synctex for luatex and xetex is a safer than testing that without srcltx dvi works on other platforms? > 2) > The LFUN_FORWARD_SEARCH implementation relies on the correct check in > getStatus. The patch adds the explicit check for presence of current buffer > and active output_sync state. Regarding the latter I???m not sure if someone > is unhappy with it. In case of preamble code to activate synctex the > LFUN_FORWARD_SEARCH would work but LyX doesn???t know that and it???s > disabled. What is your opinion here? - I would naively expect that check for buffer is enforced by dispatch (unless NoBuffer flag for lfun is specified, which won't be in this case). But I might miss something. - It did not happen to me that I needed direct preamble editing for sync so it seems we are rather on the safe side to check output_sync state. On the other hand what is the drawback of allowing the lfun regardless of output_sync state? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
