Am Dienstag, dem 13.10.2020 um 18:13 -0400 schrieb Richard Kimberly
Heck:
> First, there is a nodelim member for the latexarg struct, but there
> does
> not seem to be any way to set it. Is this an oversight? If so, I can
> write the necessary code.

It was there but has been removed by you at 6f643e52d43423

As of that commit listpreamble is broken (it inserts bracket
delimiters, whereas it should insert no delimiters at all).

Re-fixed now.

> Second, this looks puzzling to me:
> 
> void addArgInsets(Paragraph const & par, string const & prefix,
>                  Layout::LaTeXArgMap const & latexargs,
>                  map<int, InsetArgument const *> & ilist,
>                  vector<string> & required)
> {
>     for (auto const & table : par.insetList()) {
>         InsetArgument const * arg = table.inset->asInsetArgument();
>         if (!arg)
>             continue;
>         if (arg->name().empty()) {
>             LYXERR0("Error: Unnamed argument inset!");
>             continue;
>         }
>         string const name = prefix.empty() ?
>             arg->name() : split(arg->name(), ':');
> 
> At least at first glance, it seems as if we ought to be checking if
> the
> RIGHT prefix is present here. If not, why not?

What do you mean by "RIGHT prefix"? The prefix here is the type
indicator, e.g. "item:". It is passed to the function.

Jürgen

> 
> Riki
> 
> 

Attachment: signature.asc
Description: This is a digitally signed message part

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to