Am Mo., 16. Nov. 2020 um 21:34 Uhr schrieb Kornel Benko <kor...@lyx.org>:
> Am Mon, 16 Nov 2020 19:45:15 +0100 > schrieb Yu Jin <yu_...@lyx.org>: > > Ok then, I guess I can try to make a patch, I just don't understand one > > thing. In 2.3.x when I initially run configure, it gives me an error that > > the GNUWIN32_DIR is missing, but it displays all the other options in the > > CMake GUI too. In master (if I delete the line 9) currently it only > > displays just a few options (I attached 2 screenshots), so I would need > to > > specify GNUWIN32_DIR and then hit configure, then I will get another > error > > and only then I see the other options. i mean I need to hit configure 2 > > times instead of 1. In master it used to be the way it is in 2.3.x too > not > > long ago, but it is not anymore. It is just a QOL change, but I want to > ask > > if it is possible to restore the old behavior. > > The error message states that it comes from > development/cmake/modules/FindGNUWIN32.cmake. > This is _our_ Windows-file, so you are free to modify it to your liking. > At the moment the search is > $ENV{PROGRAMFILES}, > "C:/" > "D:/" > "E:/" > "F:/" > "G:/" > Add here > "D:/LyX/lyx-unstable/lyx-windows-deps-msvc2017" > > If I understood, this directory should contain "gnuwin32" and "win32libs". > > The call to determine GNUWIN32 in > development/cmake/modules/LyXPaths.cmake:61 states > "REQUIRED", so the stop is here if not found. > > "include(LyXPaths)" > > In master it is called before the options, > while in branch it is called after the options specs. > Yeah, thought so. I tried to move it behind the options which end at line 250 something. But then I get this error instead: CMake Error at development/cmake/modules/FindQt4.cmake:1037 (message): Qt qmake not found! Call Stack (most recent call first): CMakeLists.txt:813 (find_package) and GNUWIN32_DIR is not asked, I put: message(STATUS "GNUWIN32_DIR: ${GNUWIN32_DIR}") right after that include and it shows: GNUWIN32_DIR: so the variable is empty, but CMake doesn't output an error and it also doesn't show this variable in the GUI. -- Eugene
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel