On 11/1/20 4:03 PM, Yuriy Skalko wrote:
>> Apart from patches 5 & 10 these seem ok to me.
>> I am not sure we want to ditch that bformat version, just because its
>> not currently used, someone might have opinion.
>> I do not understand yet why the changes in AuthorList in 10.
>>
>> Pavel
>
> Pavel, thanks for reviewing patches!
> I've committed that 8 patches.
>
> We can leave that bformat version and to remove code duplication just
> delegate it to the version with docstring argument, as in attached patch.
Makes sense to me.
> I've started patch #10 after I saw `const` in this code:
>
> void setUsed(bool u) const { used_ = u; }
>
> It works because used_ is declared as mutable. Is it really meant to
> work this way (with breaking constness)? The rest changes followed
> removing const here to allow compilation.
>
> Maybe it is not worth to go this deep since const in C++ is not
> reliable and cannot guarantee constness of the object: in LyX there
> are many const methods that modify private implementation via d
> pointer (Buffer, Paragraph, etc).
Yes, for sure. Let me have a look at this and see what makes sense.
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
