Le 25/08/2020 à 07:17, Stephan Witt a écrit :
I would propose to either define Inset::asInsetBibitem() and use that, or rely
only on dynamic_cast. But it is not necessary to rely on inset code IMO (I try
to reduce the amount of such code uses, but they creep back relentlessly :).
So, this patch would be appreciated? :)
Well, it would be if we decided to use dynamic_cast everywhere :)
Personally, my only gripe is the keyword is too long and disrupts
reading of code. I would prefer
as<InsetSpecialChar *>(inset)
but I understand it is a bit short :)
So feel free to apply your patch, is is more c++-ish AFAIU.
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
