Re: [LyX/master] Forgotten break in switch found by coverity scan.

[Jean-Marc Lasgouttes]

Le 24/08/2020 à 16:55, Jean-Marc Lasgouttes a écrit :

commit ee3a7113167b45627cca36fc1caf376cac6ef9df
Author: Jean-Marc Lasgouttes <lasgout...@lyx.org>
Date:   Mon Aug 24 17:21:04 2020 +0200

     Forgotten break in switch found by coverity scan.

Pavel, if I got it wrong, the fall-through should be documented.

JMarc

PS: I'm back.

---
  src/frontends/qt/GuiView.cpp |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index cdd99f1..5c1c357 100644
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -4624,9 +4624,9 @@ void GuiView::dispatch(FuncRequest const & cmd, 
DispatchResult & dr)
                        dr.screenUpdate(Update::Force);
                        break;

- case LFUN_CITATION_OPEN: {

+               case LFUN_CITATION_OPEN:
                        frontend::showTarget(argument);
-               }
+                       break;

default:

                        // The LFUN must be for one of BufferView, Buffer or 
Cursor;

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel