On Wed, Aug 12, 2020 at 12:41:00PM +0200, Jürgen Spitzmüller wrote: > Am Mittwoch, den 12.08.2020, 11:52 +0200 schrieb Enrico Forestieri: > > First of all, the fix for #8384 does not work if an inset is not the > > first thing in a selection. > > That's what I fixed.
Good. I now checked it. However, the switch is not closed after the inset. > > Secondly, I don't think the inheritFont() > > method is the right thing to use in this case. The fix should apply > > when a > > paragraph break can occur, and this has nothing to do with > > inheritFont(). > > I know. But we use inheritFont() for that purpose, at least in table. This is logically wrong and does not allow to fix in a straightforward way #10263, for example. > > Please, can you revert 1af67974 and then apply the attached patch to > > see > > whether what you fixed remains fixed? The patch modifies the fix for > > #8384 > > so that only a multipar inset is enclosed in a font switch, wherever > > it > > occurs in a selection. > > Can you please make a new diff against current head? I really have no > time now to do this. I do not understand what you mean. You should simply revert 1af67974 and the apply that patch. -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
