On 7/19/20 9:10 PM, Thibaut Cuvelier wrote: > On Mon, 20 Jul 2020 at 03:05, Richard Kimberly Heck <rikih...@lyx.org > <mailto:rikih...@lyx.org>> wrote: > > On 7/19/20 8:25 PM, Scott Kostyshak wrote: > > On Mon, Jul 20, 2020 at 01:57:53AM +0200, Thibaut Cuvelier wrote: > >> On Sun, 19 Jul 2020 at 23:34, Pavel Sanda <sa...@lyx.org > <mailto:sa...@lyx.org>> wrote: > >> > >>> On Sun, Jul 19, 2020 at 11:19:08PM +0200, Pavel Sanda wrote: > >>>> On Sun, Jul 19, 2020 at 11:01:08PM +0200, Thibaut Cuvelier wrote: > >>>>> On Sun, 19 Jul 2020 at 22:33, Scott Kostyshak > <skost...@lyx.org <mailto:skost...@lyx.org>> > >>> wrote: > >>>>>> I get the following on the terminal when starting a new > document: > >>>>>> > >>>>>> Text.cpp (1940): Handling unknown body token: > >>> `\docbook_table_output' > >>>>>> Text.cpp (1940): Handling unknown body token: `0' > >>>>>> > >>>>> Hi Scott, > >>>>> > >>>>> I can't reproduce locally > (d6ec3d686b316b968ac306fd9aeffa10fbcdc423, > >>>>> Windows 10 x64, built with CMake, Visual C++ 2019). Here is > what I did: > >>>>> open LyX, create a new empty document (File > New), add some > content, > >>> save, > >>>>> close, reopen. > >>>> Try to open document with older format, e.g. tutorial in help > menu. > >>> I looked at the code and the offender is clear: > >>> def convert_docbook_table_output(document) in lyx_2_4.py. > >>> > >>> We usually do not create convert function unless you really > need to > >>> convert some > >>> older flag into new one etc. Just kick out this conversion > routine and set > >>> somewhere in bufferparams initialization routines this > variable to 0 if > >>> not done yet. > >>> Older docs will be set properly this way. > >>> > >> I've removed this function in the last commit. By default, it > should still > >> be zero, even without lyx2lyx doing something. At least, the > message is > >> gone for me. > > Thanks, Thibaut. The message is now gone for me. The reason I got it > > before when starting a new document is because I use a default > document, > > which was in an older format. > > I'm still puzzled why we should get that. If the lyx2lyx > conversion adds > it to the new format, then it should be read properly. Right? > > > Is it added at the right place? This error is generated at a strange > place in the code: inText::read, while this tag should be read > inBufferParams::readToken.
That's it. From the tutorial conversion: \html_be_strict false \author -712698321 "Jürgen Spitzmüller" \author -131811572 "Yuriy Skalko" \end_header \docbook_table_output 0 So it's coming after the header is closed. I guess we can't just append to the header then. Probably something like: document.header.insert(-1, '\\docbook_table_output 0') would be right. But Pavel's suggestion is best. Riki
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel