On 4/28/20 9:08 AM, Jean-Marc Lasgouttes wrote:
> commit 7035e230caa69a2e35f16dcf0d9696c59cef5c4c
> Author: Jean-Marc Lasgouttes <lasgout...@lyx.org>
> Date: Tue Apr 28 15:28:21 2020 +0200
>
> Avoid some more copies in range-based for loops
>
> This triggers warnings with clang++ 10.
> ---
> src/frontends/qt/Menus.cpp | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/frontends/qt/Menus.cpp b/src/frontends/qt/Menus.cpp
> index b77164b..cb30e07 100644
> --- a/src/frontends/qt/Menus.cpp
> +++ b/src/frontends/qt/Menus.cpp
> @@ -1356,7 +1356,7 @@ void MenuDefinition::expandToc(Buffer const * buf)
> // In the navigation menu, only add tocs from this document
> TocBackend const & backend = buf->tocBackend();
> TocList const & toc_list = backend.tocs();
> - for (pair<string, shared_ptr<Toc>> const & toc : toc_list) {
> + for (pair<const string, shared_ptr<Toc>> const & toc : toc_list) {
I've seen warnings like this, too, sometimes. The easy way to avoid them
seems to be just to use e.g.:
for (auto const & toc : toc_list) {
and let the compiler figure it out.
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
