> > Mental note (to me?!): the Bibitem, Bibtex and Include insets create an
> > inset when the appropriate menu item is selected. This is incorrect;
> > the inset should only be created when "Ok" is pressed, as with the
> > majority of insets. CREATE_XXX flags and associated code are needed.
> >
>
> You're right I suppose. Originally one of them did have this but JMarc
> didn't like the schizophrenic naming it incurred between the commandtag
> name and the minibuffer action... i.e. create vs. insert
Yes, the names are horrible.
If we consider the ubiquitous citation dialog, whose functionality is
correct...
The minibuffer and menu don't actually insert anything.
Insert->Citation Reference (LFUN_CITATION_CREATE) simply launches the
Citation popup.
If the contents of the popup are changed and if it is not associated with any
existing inset, then the popup will call lyxfunc::Dispatch with the tag
LFUN_CITATION_INSERT to actually insert the new inset in the document.
So, LFUN_CITATION_INSERT is named correctly. Anyone got any better
suggestions for LFUN_CITATION_CREATE, which I'll be the first to agree, is
horribly named?
How about LFUN_CITATION_DIALOG_SHOW?
Incidentally, John, what happened to your new, clean implementation of
LyXFunc et al?
Angus
