Am 04.01.2019 um 18:54 schrieb Enrico Forestieri <for...@lyx.org>: > > On Fri, Jan 04, 2019 at 05:19:57PM +0100, Stephan Witt wrote: >> Am 04.01.2019 um 17:05 schrieb Enrico Forestieri <for...@lyx.org>: >>> Then why not using a wrapper that takes the specified paths, makes them >>> absolute by prefixing the current directory if they are relative and then >>> calls the inkscape shell script? >> >> Because it’s tedious and error prone to handle all possible parameters and >> care for spaces in path names and don’t change other parameters. > > I see. In this case, in order to keep the same meaning, "$$i" and "$$o" > should always produce relative paths and the code should be audited for > adding "$$p" where actually needed. > > -- > Enrico
The argument from JMarc about possible breaking existing user preferences is a real strong one. I don’t have a better idea... the attached patch would be a real pragmatic approach, IMO. Furthermore it gives the possibility to solve (or hide) the problem in 2.3.x branch too. If this patch is not acceptable I think the next best move is to catch the relative path names in the Mac specific inkscape wrapper script. Just as you proposed it. I thought about it and think it’s doable because the calls from Converters::convert use normalized file names without spaces returned by DocFileName::mangledFileName. What do you think? Stephan
GraphicsConverter.patch
Description: Binary data
