On Wed, Jan 02, 2019 at 06:53:09PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/01/2019 à 05:22, Scott Kostyshak a écrit : > > When compiling master with clang, I get a lot of warnings. Almost all of > > them are from -Winconsistent-missing-override. Are these worth > > addressing? There is also one warning from -Woverloaded-virtual. > > The warnings have been addressed now. I guess I could have removed the one > use of Q_DECL_OVERRIDE instead, with the same result ;) > > Consider doing the same for all classes on a rainy day...
Thanks. Just checked and almost all of them are gone. I still get the
following:
In file included from
/home/scott/lyxbuilds/master_clang/repo/src/EnchantChecker.cpp:14:
/usr/include/enchant/enchant++.h:55:25: error: 'enchant::Exception::what' hides
overloaded virtual function [-Werror,-Woverloaded-virtual]
virtual const char * what () throw() {
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/exception.h:69:5:
note: hidden overloaded virtual function 'std::exception::what' declared here:
different qualifiers (const vs none)
what() const _GLIBCXX_TXN_SAFE_DYN _GLIBCXX_USE_NOEXCEPT;
^
Scott
signature.asc
Description: PGP signature
