On Wed, Jan 02, 2019 at 06:45:51AM +0100, Kornel Benko wrote: > Am Dienstag, 1. Januar 2019 18:09:51 CET schrieb Scott Kostyshak > <skost...@lyx.org>: > > The following ctest fails on 2.3.x and on master: > > > > ctest -R "export/examples/thesis/Bibliography_lyx21" > > > > It seems that the warning comes because Bibliography.lyx is included in > > more than one document that is loaded. That is, I guess that at least > > two of these .lyx files are opened (because of dependencies) when > > exporting Bibliography.lyx: > > > > Appendix.lyx > > chapter-1.lyx > > chapter-2.lyx > > thesis.lyx > > > > This does not seem like a bug to me. My guess is that this test never > > passed (although I'm not sure). The following warnings occur: > > > > Buffer.cpp (361): Warning: a buffer should not have two parents! > > > > And, on the second iteration (that is, exporting the created 2.1.x file > > again to 2.1.x format to create a .21.21.lyx file): > > > > Buffer.cpp (1062): The master 'thesis.lyx' assigned to this document > > (/home/scott/lyxbuilds/master/repo/lib/examples/thesis/Bibliography.21.lyx) > > does not include this document. Ignoring the master assignment. > > > > I guess this is because for the second iteration, the file has 21.lyx > > instead > > of .lyx. > > > > Kornel, do you think we should ignore both of these warnings for all > > lyx2lyx tests? I attempted to do that (see attached), but the test still > > fails and I'm not sure if it's because I did not ignore the warnings > > correctly or if there's another issue. > > No, it is a child-documents. Other child are already removed from test.
Ah I see. > $ egrep thesis *Tests > ignoredTests:export/examples/thesis/(Acknowledgments|Appendix|Summary|chapter-[12])_lyx[0-9][0-9] > > > An alternative I suppose would be > > to just not run these tests (by "ignoring" them). Any thoughts? > > Yes, please do also for master. Makes sense. Feel free to go ahead, or I will get to this tomorrow. We also have the following test failing (at least for me) on master: ctest -R "export/examples/thesis/thesis_lyx21" Adding Warning: a buffer should not have two parents! to filterCheckWarnings fixes it for me. Is that the right thing to do? Scott
signature.asc
Description: PGP signature
