On 01/11/2018 02:02, Scott Kostyshak wrote:
On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote:
On 31/10/2018 16:05, Scott Kostyshak wrote:
On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:
Thanks for checking. The minimum height was actually a bit imprecise. I
should have written: "fixed at minimum height". In current
master you can
increase the height but I couldn't see what is to be gained
by this and many
other apps have fixed height find dialogs.
Ah I see. Thanks for the explanation. Seems reasonable to me.
Great. When I find time, I go ahead and fix what seem to me
positioning issues in the other dialogs.
Daniel
Spellchecker dialog.
Thesaurus dialog.
What's the intuition behind this change? I haven't decided yet whether I
like the before or the after better, but I'm curious why you propose
this change. Are you thinking of only aesthetics? Or are you think that
sometimes users want to enter a long keyword? As for why large buttons
might be useful, well you don't need to have pinpoint accuracy with the
mouse. I wonder what UI guides say. Probably they have some guidelines
on which elements to stretch, and I wouldn't be surprised if your
changes are in accordance with the guidelines. I'm just giving my first
impression.
Thanks for your work on these dialogs.
Scott
Thanks for checking. That the left hand labels don't stretch was driven by
the idea that it would be easier to match the label and the text boxes. As
for the buttons: I have never seen a (professional) dialog UI where the
buttons stretch. So, I suggest to stick to what has been used elsewhere.
(Probably for good reason but I am not sure about what that might be.) Also,
my hunch was that this stretching behaviour was unintentional because it
does not appear so long as the dialog is kept to a narrow width.
Makes sense. Thanks,
Scott
Great. And by the way, while I tend to think all the changes I make
sense, I can change things on feedback. Also, if you come across some
oddity in a dialog that I haven't caught yet, please let me know. I
think I got the hang of Qt Creator.
Daniel
