Am Freitag, 26. Oktober 2018 10:14:46 CEST schrieb Tommaso Cucinotta <tomm...@lyx.org>: > On 24/10/18 18:51, Kornel Benko wrote: > > (Having a GUI for selection of which attribute to ignore or not would be > > better, but designing and > > programming such a dialog is not my strength) > > > > Opinions please. > > great job, Kornel, to tackle a rework of this code, thanks! > Your proposal sounds sound, just a simple question: whether you managed to > re-run the test cases in > development/autotests, after your changes ?
I tried and failed. Then I tried some tests manually, and they worked.
After some fiddling with findadv-05, it looks like lyx is too slow. And in fact
using 'KD:50' made this test pass.
ATM I am concentrating on whether the findadv works in 'normal' situations.
I have a BIG problem with regexes containing accented characters. The reason is
that
lyx handles regexes in MATH_MODE and changes all occurrences of say 'ä' to
\ddot{a}.
So the input of [a-zä]+ results in
regexp{[a-z\ddot{a}]+endregexp{}}
and of course does not match the desired.
I failed to find out where this substitution is done.
FWIW, '\w' does not work either in this case, because it does not recognize
'ä' as a valid character. This is VERY ascii centric IMHO.
> Is this now all pushed to master? I'll need to have a try soon.
Yes, but the last one. Anyway, lyx.org is not available ATM, so no commit
possible.
But of course I will post a patch if desired.
> T.
Kornel
diff --git a/development/autotests/findadv-05-in.txt b/development/autotests/findadv-05-in.txt index a3ea5e3..0fcf149 100644 --- a/development/autotests/findadv-05-in.txt +++ b/development/autotests/findadv-05-in.txt @@ -1,10 +1,11 @@ # Basic test for format-aware searching # Lang sk_SK.utf8 CO: findadv-05.ctrl TestBegin test.lyx -dbg key,find > findadv-05.loga.txt 2>&1 +KD: 50 CN: Part 1 KK: foo \Cefoo foo\Ce foo\C\[Home] KK: \Cs KK: \CF # Uncheck ignore format
signature.asc
Description: This is a digitally signed message part.
