On Sun, Oct 14, 2018 at 12:56:34PM +0200, Enrico Forestieri wrote: > On Sat, Oct 13, 2018 at 11:36:46PM -0400, Scott Kostyshak wrote: > > On Sun, Oct 07, 2018 at 11:56:45AM -0400, Scott Kostyshak wrote: > > > On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote: > > > > Le 04/09/2018 à 03:55, Scott Kostyshak a écrit : > > > > > If I have an ERT in a preview inset, it previews when I open LyX. But > > > > > if > > > > > I zoom in or out, the preview is not refreshed. > > > > > > > > > > I did a bisect that lead me here. Note that I did the bisect on 2.3.x. > > > > > > > > > > Can anyone reproduce? > > > > > > > > I also have issues with preview working at times and then not. I do not > > > > see > > > > at this point how this could be related to this commit, though. > > > > > > Good to know. Thanks for taking a look. > > > > For some reason, PreviewLoader::Impl::refreshPreviews() is no longer > > called for me. Enrico, can you reproduce? > > Yes, I can reproduce. I also find that PreviewLoader::Impl::refreshPreviews() > gets called if one places the cursor into a math inset after changing the > zoom. I am attaching a test document and a debug patch to demonstrate it. > 1) Load the test document after applying the patch. > 2) Place the cursor outside the math inset and change zoom. > 3) Quickly click into the math inset to place the cursor there and wait > for the message "Updating previews". > 4) Move the cursor out of the math inset and see that now the preview has > been correctly generated.
Ah good to know. JMarc, could the cursor placement observation that Enrico mentions above be a clue for something that changed related to this commit or the previous commit (7b8b3e38)? > > Do you have an idea if the > > code that takes care of the preview regeneration on zoom change could > > have been broken by something? > > No, I have no idea of what change introduced this regression. OK thanks for taking a look. Scott
signature.asc
Description: PGP signature
