On Thu, May 10, 2018 at 11:26:41AM +0000, Jean-Marc Lasgouttes wrote: > Le 08/05/2018 à 02:04, Scott Kostyshak a écrit : > > The patch is attached. Any comments? > > It looks good.
Thanks, it's in at 23de5e5e. > > In addition, I have a couple of questions: > > > > 1. Is there a reason that there is no const_DocIterator class? > > No, what would it be good for? It would make it easier to read the code. For example, I would know that methods such as forwardPar() could be used, but that no changes to the document would be done. But perhaps it is not clear what a "change" is. > > > 2. If paragraph::id() did not exist, would it be reasonable to do > > something like the following? > > > > if (&it.paragraph() == &cur.selectionEnd().paragraph()) > > ... > > Yes, I think so. Thanks, Scott
signature.asc
Description: PGP signature
