On Tue, 13 Mar 2001, Angus Leeming wrote:
> On Tuesday 13 March 2001 13:27, Jean-Marc Lasgouttes wrote:
> > >>>>> "John" == John Levon <[EMAIL PROTECTED]> writes:
> >
> > John> Attached is a fixed FormInclude. It's quite a large patch as I
> > John> changed insetinclude a bit.
> >
> > It is fine with me and I could apply it, but I'd like first to hear
> > from Angus wrt the changes in Params and also where and how the
> > buffer_ parameter should be handled. I know he did a lot of work on
> > these problems...
>
> SIgh...
>
> John has added a "Buffer const * buffer;" to InsetIncludeParams. I'm sure
> Lars and Jürgen were pretty elequent about why storing a Buffer * in ANY
> inset was a bad thing and that we should move to Buffer transparent insets.
>
> Ie, we should pass a (Buffer const &) to any inset method that required it,
> rather than store it.
Can I just point out I didn't *add* this, I simply moved it - it was already
a member of insetinclude.C
How can I store a Buffer const & in the Params struct and keep
Params as a member variable of InsetInclude, when the Params has a c-tor
(that's a C++ question)
thanks
john
--
"Alan Turing thought about criteria to settle the question of whether
machines can think, a question of which we now know that it is about
as relevant as the question of whether submarines can swim."
- Dijkstra
