Scott Kostyshak wrote:
> current call faster on large documents. e.g. you could change
> 
>   cur.countInsetsInSelection(GRAPHICS_CODE)>1)
> 
> to
> 
>   cur.countInsetsInSelection(GRAPHICS_CODE, 2) == 2
> 
> If you are not having fun, I would be happy to make this change (but

That would be nice.

> please give feedback as to whether you think it is a good idea). If so,

No strong opinion / I'm not sure how much single pass via dociterator costs
nowadays if you select big document. If we talk tenths of ms, I'd say no
optimizations necessary, if we talk hundreds of ms then having bunch
of these checks in context menu could cost us untrivial delay...

> go ahead and commit your current code and I will make the extension.

Ok, will commit once back home.

Pavel

Reply via email to