Am Montag, 8. Januar 2018 um 23:20:24, schrieb Guenter Milde <mi...@users.sf.net> > On 2018-01-02, Kornel Benko wrote: > > Am Dienstag, 2. Januar 2018 um 08:58:47, schrieb Günter Milde > > <mi...@lyx.org> > >> commit 20f3b828f942f8b6d76fb48fd34f9187532092d8 > >> Author: Günter Milde <mi...@lyx.org> > >> Date: Mon Jan 1 22:52:08 2018 +0100 > > >> Documentation fixes: revert conversion of -- to en dash in code. > > >> lyx2lyx erroneousely merged -- to en dash in text with logical > >> markup "code". > >> Revealed by recent (but now silenced) ctest fails. > > >> Also add space around en dash in examples. > > > So we should enable the test again? > > Tricky: > > Just turning off an "offending" test is not a good idea generally.
Yes. > The test failures reveales several problems: > > a) Wrong conversion of -- in "Code" logical markup insets (see #10961). > b) Missing spacing around en dash in several documents. > c) "False positive" warning from the lyx2lyx converter. > > However: > > While problems a) and b) are now solved, problem c) still leads > (spurious) warnings of possible line-break changes. > > > The problem is in the limited detection capability in the lyx2lyx converter: > Currently, there is no reliable test for the current font in lyx2lyx. > > We can invert the failing tests as LyX-bug (#10836) > :( > It may be that the patch > http://www.lyx.org/trac/raw-attachment/ticket/10961/0001-Do-not-convert-dasheshyphens-in-Code-insets-logical-markup.patch > already fixes the Additional.lyx tests. This seems already applied. > Eventually, we also need to skip -- to \twohyphens conversion in typewriter, > see appended patch. (With reverted changes of filterCheckWarnings) Without your patch all lyx22-exports pass 7 lyx21-exports fail out of 338 1641 - export/doc/UserGuide_lyx21 (Failed) 2080 - export/doc/de/UserGuide_lyx21 (Failed) 2112 - export/doc/es/Additional_lyx21 (Failed) 2320 - export/doc/fr/Additional_lyx21 (Failed) 2672 - export/doc/ja/Additional_lyx21 (Failed) 3525 - export/examples/lilypond_lyx21 (Failed) 5369 - export/examples/ja/lilypond_lyx21 (Failed) With your patch applied all lyx22-exports pass 184 lyx21-exports fail out of 338 (Too many to list) > Sorry for the delay, No problem. > Günter Kornel
signature.asc
Description: This is a digitally signed message part.
