On Sun, Oct 15, 2017 at 05:27:30PM +0000, Richard Heck wrote: > On 10/15/2017 12:52 PM, Scott Kostyshak wrote: > > On Sun, Oct 15, 2017 at 04:17:21PM +0000, Richard Heck wrote: > >> commit de2a58d986739bccb83615e8515d715ebf1b5821 > >> Author: Richard Heck <rgh...@lyx.org> > >> Date: Thu Jun 30 14:53:19 2016 -0400 > >> > >> Fix bug #8782. > >> > >> We need to invalidate the BibTeX cache when undoing or redoing. I do > >> not like having to do it for every undo or redo. We should only have > >> to do it if we restored or deleted an InsetBibTeX. But there is no > >> way, so far as I can see, to do it that way. I tried. > >> > >> (cherry picked from commit 02847641a8b97a57d1866120bb446427e0bda7a4) > >> --- > > This is the commit that bisect lead me to when experiencing a very > > slight delay after an undo [1]. The delay is very small for me, but we > > are not sure whether this commit is also why racoon experiences a > > one-second delay. Perhaps this issue is important enough that we would > > accept a one-second delay. I just wanted to mention this though. > > > > I will CC Uwe on the main thread [1]. Hopefully he can reproduce the > > issue racoon sees so we can figure out the root problem. > > Oh, yes! Sorry, I missed that other message. This would do it, and it is > exactly the kind of change > I was thinking might cause this. It does force a re-read of the BibTeX > files, so how long a delay you > see will depend upon how big the files are, etc.
Note that a7677bfb (the reversion commit) introduced another issue: To reproduce: 1. Open e.g. tufte-handout.lyx (any LyX file with a citation inset will reproduce) 2. Scroll down to a citation inset and remember how it looks. e.g. "[#Bringhurst2005]". 3. Go to Document > Settings > Bibliography and change BibTeX to Biblatex. Press "OK". 4. Undo. The citation inset is not restored to the same as before, "[#Bringhurst2005]". Instead, it looks the same as before undo: "Bringhurst 2005". Scott
signature.asc
Description: PGP signature
