Hoping/testing if a simple reply works and is added to the ticket. I think this is an excellent improvement. However, I'd like to suggest that instad of storing a timestamp, we should store a hash of the document's contents.
I'm not sure if it's necessary to include the file name in what's hashed. For instance, let's say we approve running (the content of) doc1.lyx. Would we automatically be ok with running (the content of) an identical document named doc_with_a_different_name.lyx? Perhaps it'd be nice if the hash could be done only on the "code" parts. OTOH, perhaps we can't be sure that the code parts don't depend on the content of the non-code parts. Similarly, in theory the code parts could perhaps depend on the name of the document, or it's absolute path. /C On 29 July 2017 at 02:03, LyX Ticket Tracker <t...@lyx.org> wrote: > #10735: needauth - ask again authorization if file (or script snippet) > changes > -------------------------+---------------------- > Reporter: t.cucinotta | Owner: rgheck > Type: enhancement | Status: new > Priority: normal | Milestone: > Component: converters | Version: 2.3.0dev > Severity: normal | Keywords: > -------------------------+---------------------- > Related to #10481. > > If I authorize conversion on a file, its absolute filepath is remembered > by LyX, in a section of $HOME/.lyx/session. If the document is updated > later, e.g., saved from an e-mail, updated from git/svn/cvs, then said > authorization should be automatically revoked. > Namely, we need to store in the session also the timestamp of the last > authorized file, so that, when it changes, we ask authorization again. > > -- > Ticket URL: <http://www.lyx.org/trac/ticket/10735> > The LyX Project <http://www.lyx.org/> > LyX -- The Document Processor >
